PSA: breaking change for C++ custom printer/parser

In this revision, we’re changing the API contract between the MLIR printer and the custom hook for operations: the framework will take control of printing the operation name.

If you’re using the ODS declarative assembly format you won’t be affected by this change, but if you have C++ written assembly printer, you need to remove the printing of the operation name (or maybe it is a good opportunity to switch to the declarative assembly :wink: ).

5 Likes

This landed. There is one extra change that got bundled in there in that the builtin dialect does not parse by default anymore (other than at the top-level for module basically). So any nested op like unrealized_cast will need to be prefixed with builtin..

In the future we’ll like move the standard dialect to require to be prefixed in the same way.

2 Likes

Great work Mehdi!