[6.0.0 Release] Release Candidate 1 tagged

Dear testers,

Start your engines; 6.0.0-rc1 was just tagged.

I know there are still open blockers and it's early in the process in
a way, but I'd like to find out where we are. Please run the test
script, let me know the results, and upload binaries.

Thanks,
Hans

All Zig tests passed with LLVM, LLD, Clang 6.0.0-rc1, Debug, assertions enabled.

We're now using it as the main compiler in the OpenMandriva
development builds -- no issues so far (after rebuilding a couple of
key packages for testing).

ttyl
bero

Hi,

Uploaded ARM & AArch64:
b84b25397a4ea479d08c056b20582fd0a8e16bb6
clang+llvm-6.0.0-rc1-aarch64-linux-gnu.tar.xz
c19100cf7fb1d0fea80ed3e761bfd293e807b59a
clang+llvm-6.0.0-rc1-armv7a-linux-gnueabihf.tar.xz

I am seeing some failures in compiler-rt (ARM, AArch64) and libcxx
(just ARM), for which I have filed PR35996 and PR35997.

Cheers,
Diana

For an overview of what failed in the FreeBSD ports collection, with a 6.0.0 snapshot corresponding to trunk r321545, see here:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224669

Roughly 24,000 ports were built, 500 failed, and those caused ~4,400 other ports not to be built.

A number of crashes were already reported on the LLVM bugtracker, and some other important packages were already fixed. But all is definitely not clear yet. :slight_smile:

-Dimitry

Uploaded

afeb7f66eedd4d576ba8df9b4a551bb1908186e6 clang+llvm-6.0.0-rc1-linux-x86_64-sles11.3.tar.xz

At the moment I can't compile openmp, since it errors out on libomptarget:

/home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:50:10: error: use of undeclared identifier 'malloc'
    rc = malloc(size);
         ^
/home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:76:5: error: use of undeclared identifier 'free'
    free(device_ptr);
    ^
/home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:163:20: error: use of undeclared identifier 'malloc'
    void *buffer = malloc(length);
                   ^

I'm trying a local fix here, namely including <cstdlib> at the top of the file.

-Dimitry

Argh, I have missed that header. Adding <cstdlib> sounds like the right solution, can you submit a patch or directly commit to SVN if it works for you?

If anyone else has problems building libomptarget in Debug: <string> was missing in rtl.{cpp,h} which has been merged this morning after rc1 was tagged.

Regards,
Jonas

I added <cstdlib> to api.cpp, interface.cpp and rtl.cpp, in r322869. Hans, could you please merge it to release_60, or shall I do it?

-Dimitry

W dniu śro, 17.01.2018 o godzinie 18∶53 +0100, użytkownik Hans Wennborg
via Release-testers napisał:

Dear testers,

Start your engines; 6.0.0-rc1 was just tagged.

I know there are still open blockers and it's early in the process in
a way, but I'd like to find out where we are. Please run the test
script, let me know the results, and upload binaries.

Well, initial results for Gentoo are not good. Looks like there are
a number of regression for stand-alone builds of everything, and LLDB
is still completely broken with mysterious (not a regression):

  error: process launch failed: 'A' packet returned an error: -1

Regressions:

- lld: tests broken with stand-alone builds (reported [1], patch
submitted [2]),

- lldb: few unittest breakages (backported already [3]),

- compiler-rt: a few unittest breakages (still need to investigate,
can possibly be related to stand-alone builds, will report bugs later),

- libcxx/libcxxabi: tests broken as reported before [4].

[1]:https://bugs.llvm.org/show_bug.cgi?id=36006
[2]:https://reviews.llvm.org/D42252
[3]:https://bugs.llvm.org/show_bug.cgi?id=35991
[4]:https://bugs.llvm.org/show_bug.cgi?id=35698

Another problem I'm running into is that check-all fails with a Python ValueError. The last part of the log is (this is just after most stuff has been built, and lit is starting up):

[100%] Running all regression tests
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libunwind/test/lit.cfg:58: note: Using configuration variant: libunwind
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:307: note: inferred use_system_cxx_lib as: None
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:313: note: inferred with_availability as: False
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:345: note: inferred use_clang_verify as: True
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:355: note: enabling thread-safety annotations
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:535: note: inferred language dialect as: c++2a
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:436: note: inferred long_tests as: True
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:156: note: Using compiler: /home/dim/llvm-6.0.0/rc1/Phase2/Release/llvmCore-6.0.0-rc1.install/usr/local/bin/clang++
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:157: note: Using flags: ['-v', '-D_LIBCPP_DISABLE_AVAILABILITY', '-ftemplate-depth=270']
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:162: note: Using compile flags: ['-Werror=thread-safety', '-DLIBUNWIND_NO_TIMER', '-fno-exceptions', '-DLIBUNWIND_HAS_NO_EXCEPTIONS', '-funwind-tables', '-std=c++2a', '-I/home/dim/llvm-6.0.0/rc1/llvm.src/projects/libunwind/include', '-Itest/support']
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:164: note: Using warnings: ['-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER', '-Wall', '-Wextra', '-Werror', '-Wuser-defined-warnings', '-Wshadow', '-Wno-unused-command-line-argument', '-Wno-attributes', '-Wno-pessimizing-move', '-Wno-c++11-extensions', '-Wno-user-defined-literals', '-Wno-noexcept-type', '-Wno-aligned-allocation-unavailable', '-Wsign-compare', '-Wunused-variable', '-Wunused-parameter', '-Wunreachable-code', '-Wno-conversion', '-Wno-unused-local-typedef', '-Wno-#warnings']
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:165: note: Using link flags: ['-L/home/dim/llvm-6.0.0/rc1/Phase3/Release/llvmCore-6.0.0-rc1.obj/./lib', '-Wl,-rpath,/home/dim/llvm-6.0.0/rc1/Phase3/Release/llvmCore-6.0.0-rc1.obj/./lib', '-nodefaultlibs', '-lc++', '-lc++abi', '-lc', '-lm', '-lpthread', '-lgcc_s', '-lcxxrt']
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:168: note: Using available_features: ['libc++', 'verify-support', 'clang-6', 'modules-support', 'locale.en_US.UTF-8', 'diagnose-if-support', 'long_tests', 'fdelayed-template-parsing', '-faligned-allocation', 'c++2a', 'locale.fr_CA.ISO8859-1', 'clang', 'locale.fr_FR.UTF-8', 'libcxxabi-no-exceptions', 'locale.ru_RU.UTF-8', 'fsized-deallocation', 'locale.zh_CN.UTF-8', 'freebsd10', 'fcoroutines-ts', 'locale.cs_CZ.ISO8859-2', 'clang-6.0', 'thread-safety']
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:173: note: Adding environment variables: {}
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/test/lit.cfg:45: note: Using configuration variant: libcxx
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:307: note: inferred use_system_cxx_lib as: None
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:313: note: inferred with_availability as: False
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:345: note: inferred use_clang_verify as: True
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:355: note: enabling thread-safety annotations
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:535: note: inferred language dialect as: c++2a
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:436: note: inferred long_tests as: True
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:156: note: Using compiler: /home/dim/llvm-6.0.0/rc1/Phase2/Release/llvmCore-6.0.0-rc1.install/usr/local/bin/clang++
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:157: note: Using flags: ['-v', '-D_LIBCPP_DISABLE_AVAILABILITY', '-ftemplate-depth=270']
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:162: note: Using compile flags: ['-Werror=thread-safety', '-std=c++2a', '-include', '/home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/test/support/nasty_macros.hpp', '-nostdinc++', '-I/home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/include', '-I/home/dim/llvm-6.0.0/rc1/Phase3/Release/llvmCore-6.0.0-rc1.obj/projects/libcxx/include/c++build', '-I/home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/test/support', '-DLIBCXX_FILESYSTEM_STATIC_TEST_ROOT="/home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/test/std/experimental/filesystem/Inputs/static_test_env"', '-DLIBCXX_FILESYSTEM_DYNAMIC_TEST_ROOT="/home/dim/llvm-6.0.0/rc1/Phase3/Release/llvmCore-6.0.0-rc1.obj/projects/libcxx/test/filesystem/Output/dynamic_env"', '-DLIBCXX_FILESYSTEM_DYNAMIC_TEST_HELPER="/usr/local/bin/python2.7 /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/test/support/filesystem_dynamic_test_helper.py"']
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:164: note: Using warnings: ['-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER', '-Wall', '-Wextra', '-Werror', '-Wuser-defined-warnings', '-Wshadow', '-Wno-unused-command-line-argument', '-Wno-attributes', '-Wno-pessimizing-move', '-Wno-c++11-extensions', '-Wno-user-defined-literals', '-Wno-noexcept-type', '-Wno-aligned-allocation-unavailable', '-Wsign-compare', '-Wunused-variable', '-Wunused-parameter', '-Wunreachable-code', '-Wno-conversion', '-Wno-unused-local-typedef', '-Wno-#warnings']
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:165: note: Using link flags: ['-L/home/dim/llvm-6.0.0/rc1/Phase3/Release/llvmCore-6.0.0-rc1.obj/./lib', '-Wl,-rpath,/home/dim/llvm-6.0.0/rc1/Phase3/Release/llvmCore-6.0.0-rc1.obj/./lib', '-L/home/dim/llvm-6.0.0/rc1/Phase3/Release/llvmCore-6.0.0-rc1.obj/./lib', '-Wl,-rpath,/home/dim/llvm-6.0.0/rc1/Phase3/Release/llvmCore-6.0.0-rc1.obj/./lib', '-nodefaultlibs', '-lc++experimental', '-lc++', '-lc', '-lm', '-lpthread', '-lgcc_s', '-lcxxrt']
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:168: note: Using available_features: ['libc++', 'verify-support', 'clang-6', 'modules-support', 'locale.en_US.UTF-8', 'diagnose-if-support', 'long_tests', 'fdelayed-template-parsing', '-faligned-allocation', 'c++2a', 'locale.fr_CA.ISO8859-1', 'c++filesystem', 'c++experimental', 'clang', 'locale.fr_FR.UTF-8', 'locale.ru_RU.UTF-8', 'fsized-deallocation', 'locale.zh_CN.UTF-8', 'freebsd10', 'fcoroutines-ts', 'locale.cs_CZ.ISO8859-2', 'clang-6.0', 'thread-safety']
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/projects/libcxx/utils/libcxx/test/config.py:173: note: Adding environment variables: {'LIBCXX_FILESYSTEM_DYNAMIC_TEST_ROOT': '/home/dim/llvm-6.0.0/rc1/Phase3/Release/llvmCore-6.0.0-rc1.obj/projects/libcxx/test/filesystem/Output/dynamic_env'}
llvm-lit: /home/dim/llvm-6.0.0/rc1/llvm.src/utils/lit/lit/discovery.py:244: warning: input '/home/dim/llvm-6.0.0/rc1/Phase3/Release/llvmCore-6.0.0-rc1.obj/projects/compiler-rt/test/interception/Unit' contained no tests
Traceback (most recent call last):
  File "/home/dim/llvm-6.0.0/rc1/Phase3/Release/llvmCore-6.0.0-rc1.obj/./bin/llvm-lit", line 56, in <module>
    main(builtin_parameters)
  File "/home/dim/llvm-6.0.0/rc1/llvm.src/utils/lit/lit/main.py", line 161, in main
    main_with_tmp(builtinParameters)
  File "/home/dim/llvm-6.0.0/rc1/llvm.src/utils/lit/lit/main.py", line 357, in main_with_tmp
    lit.discovery.find_tests_for_inputs(litConfig, inputs))
  File "/home/dim/llvm-6.0.0/rc1/llvm.src/utils/lit/lit/discovery.py", line 242, in find_tests_for_inputs
    test_suite_cache, local_config_cache)[1])
  File "/home/dim/llvm-6.0.0/rc1/llvm.src/utils/lit/lit/discovery.py", line 206, in getTestsInSuite
    for res in subiter:
  File "/home/dim/llvm-6.0.0/rc1/llvm.src/utils/lit/lit/discovery.py", line 206, in getTestsInSuite
    for res in subiter:
  File "/home/dim/llvm-6.0.0/rc1/llvm.src/utils/lit/lit/discovery.py", line 164, in getTestsInSuite
    litConfig, lc):
  File "/home/dim/llvm-6.0.0/rc1/llvm.src/utils/lit/lit/formats/googletest.py", line 94, in getTestsInDirectory
    for testname in testnames:
  File "/home/dim/llvm-6.0.0/rc1/llvm.src/utils/lit/lit/formats/googletest.py", line 39, in getGTestTests
    env=localConfig.environment)
  File "/usr/local/lib/python2.7/subprocess.py", line 212, in check_output
    process = Popen(stdout=PIPE, *popenargs, **kwargs)
  File "/usr/local/lib/python2.7/subprocess.py", line 390, in __init__
    errread, errwrite)
  File "/usr/local/lib/python2.7/subprocess.py", line 1025, in _execute_child
    raise child_exception
ValueError: illegal environment variable name
gmake[3]: *** [CMakeFiles/check-all.dir/build.make:58: CMakeFiles/check-all] Error 1
gmake[3]: Target 'CMakeFiles/check-all.dir/build' not remade because of errors.
gmake[2]: *** [CMakeFiles/Makefile2:250: CMakeFiles/check-all.dir/all] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:257: CMakeFiles/check-all.dir/rule] Error 2
gmake[1]: Target 'check-all' not remade because of errors.
gmake: *** [Makefile:212: check-all] Error 2
[Release Phase3] check-all failed

I seem to remember having seen this before, where it either tried to put in an environment variable with an empty name, or one with an '=' sign in it. Does anybody have an idea what might be wrong here? Is it tripping up over the "input contained no tests" failure just before?

-Dimitry

Go ahead if you're set up, otherwise let me know and I'll do it.

Done in r323037. I have also taken the liberty of merging r322875 and r322879, in which I added a '-no-libcxxabi' option to the test-release.sh script.

-Dimitry

Thanks!

Hi Hans,

I'm seeing a number of new failures on my little endian MIPS system, which are the same
as Diana recorded in PR35997.

On my big endian MIPS system, I'm also seeing PR35997 and:

PR36056: lld test failures.

    MemorySanitizer-MIPS64 :: chained_origin.cc
    MemorySanitizer-Unit :: ./Msan-mips64-Test/MemorySanitizer.sincosf
    SanitizerCommon-tsan-mips64-Linux :: Posix/dedup_token_length_test.cc

A patch has been committed to trunk for the tsan failure (PR36059 for the merge request), and I'm investigating the msan failures.

I also hit an issue compiling the test suite: PR36058, patch posted.

X86_64 looks clean.

Binaries uploaded:
SHA256(clang+llvm-6.0.0-rc1-mipsel-linux-gnu.tar.xz)= 1e7d71c1c06bcc977fad6d4ac18cfb7e3ba58d8f30dacbd89a53893f08a5fdb0
SHA256(clang+llvm-6.0.0-rc1-mips-linux-gnu.tar.xz)= 5e9c6a58cfcf5095725138d4332b422cede86ccabde08c6ea9e13c9a2f563f17
SHA256(clang+llvm-6.0.0-rc1-x86_64-linux-gnu-debian8.tar.xz)= 64a80288daffbd5fe9f520b496a9a7d86289c116dc02ec2ddb928350e31fa00c

Thanks,
Simon

...

So, I finally managed to produce some tarballs, and uploaded them:

SHA256 (clang+llvm-6.0.0-rc1-amd64-unknown-freebsd10.tar.xz) = d93427fd2b8f5aa0d5278f1bd3020add07b8316ff8a512a203bf3c41639d7baf
SHA256 (clang+llvm-6.0.0-rc1-i386-unknown-freebsd10.tar.xz) = 9f283235fb10242b9f79527c0d895260e6efa1c1bb761c57396490c7ccd5f5f0

This was an interesting round of testing, since I attempted to build the 'libs' part for the first time, and things like libcxx, polly etc are also included. I had to apply several patches, one of which was to be able to disable libc++abi, which we can't link against yet on FreeBSD.

During the build of the test-suite, I encountered several instances of link jobs failing due to the addition of -ldl, which does not exist on FreeBSD. It is really a Linuxism, for which I will commit a few fixes. In addition, some test-suite programs fail to link on FreeBSD 10.x, since it does not yet have __cpu_model in the base system's copy of libcompiler-rt. I solved that with a local hack.

On amd64-freebsd10 there were 895 test failures:

Is there a way to download archives of the release candidates similiar to releases.llvm.org ?

Ciao
Nat!

http://prereleases.llvm.org/

Yes, that’s the place. I haven’t uploaded the binaries yet though, because there were so many problems. Do people think they’d still be useful?