A failure caused by my commits

Dear developers,

A recent call commit by me caused a build failure, due to not enough test.

Please do not revert it and I will fix it ASAP.

http://lab.llvm.org:8011/#/builders/109/builds/7148

Ben

Seems that you've reverted it
(01d9f13c3a5914baf9739348ef666e348a7b2a2f), but please mention reasons
for revert in the future.

It was not due to insufficient test. It failed on macOS and Windows
and was likely due to platform differences.

For `clang -target x86_64` and many other target triples, they behave
as generic ELF and should have the same behavior on different OSes.
You may need to check why `-target avr` is different on macOS and Windows.

I have reproduced the failures on my ubuntu server. The main reason is,

though I tested with removal of avr-gcc, the avr-libc and avr-binutils were not auto removed.

I will try the test with all avr-related things removed on both linux and windows.

Ben

The real cause is that avr clang driver omits user specified --sysroot,I have created a patch to fix that.

https://reviews.llvm.org/D95529

Ben

The real cause is that avr clang driver omits user specified --sysroot,I have created a patch to fix that.

⚙ D95529 [AVR][clang] Fix a bug in AVR toolchain search paths

Ben

Replied on D95529. Next time cfe-dev would be a more suitable list as
this is entirely Clang specific.
Using a more specific subject e.g. "Failure due to AVR driver change"
can help others filter/find this thread.