A potential race on StaticList in RegisterManagedStatic

Project Infrastructure LLVM Dev List Archives
1

Ptr member of ManagedStaticBase is now atomic.
In ManagedStaticBase::RegisterManagedStatic we have such code:

void *Tmp = Creator();

Ptr.store(Tmp, std::memory_order_release);
DeleterFn = Deleter;

// Add to list of managed statics.
Next = StaticList;
StaticList = this;

StaticList is not atomic and not guarded by any fence.
The same applies to the members DeleterFn and Next.

Doesn’t it seem reasonable to change the code to

DeleterFn = Deleter;

// Add to list of managed statics.
Next = StaticList;
StaticList = this;

Ptr.store(Tmp, std::memory_order_release);

2

Though it won’t actually help to guard this: while (StaticList) - a fence here is needed…

3

What about the lock that is taken?

MutexGuard Lock(*getManagedStaticMutex());