About Entity

Clang Frontend
1

Currently we treat all local VarDecls and struct FieldDecls as
external Entity. Shall we create them as internal Entity or make them
invalid Entity? I feel that it does not make too much sense to make
them Entities. But making them internal Entities seems no harm.

- Zhongxing

2

I would lean slightly to ‘internal’ for generality, so that functions that handle them can work on both external and local decls, but I don’t have a strong opinion on this.

But if the way is to not make them entities at all, then the concept of internal entities should be removed.

-Argiris

3

Hi Argiris,

Since the all usages of the Entity is still unclear, let's leave them
as 'internal' Entites.

4

Hi Argiris,

I have an idea to let the Entity reflect the linkage of a name. If a
name has external linkage, we make it an 'external' Entity. If a name
has internal linkage, we make it an 'internal' Entity. If a name has
no linkage, we make it an invalid Entity. What do you think?

5

Hi Zhongxing,

Hi Argiris,

I have an idea to let the Entity reflect the linkage of a name. If a
name has external linkage, we make it an ‘external’ Entity. If a name
has internal linkage, we make it an ‘internal’ Entity. If a name has
no linkage, we make it an invalid Entity. What do you think?

Makes sense; sounds good!

-Argiris