accidental interface change for __kmpc_push_target_tripcount?

Hi,

It looks like we broke backwards compatibility for the __kmpc_push_target_tripcount with this change that added location fields to libomptarget for debugging:

https://reviews.llvm.org/D87946

From the discussion in the patch review, a suffix (like _loc) was not added for the new Mapper API entry points because they weren’t released in Clang 11.x. But __kmpc_push_target_tripcount was an existing entry point. I suspect this was just overlooked?

Do we have time to get this fixed for Clang 12.x, by adding a new __kmpc_push_target_tripcount_loc?

Thanks,

Deepak

I pushed a fixed and submitted a bug report https://bugs.llvm.org/show_bug.cgi?id=49539. Anyone who was using Clang 12.x or 13.x for offloading applications will most likely need to recompile.