Add Support For .bss Named Section Directive For Darwin Targets

Project Infrastructure LLVM Dev List Archives
1

Hi - I've attached a patch to make the assembly parser recognise the
.bss directive on Darwin targets as a switch to the (__DATA,__bss)
section. The ELF & COFF assembly parsers already recongnise the .bss
directive. I've added a test case for it too. Thanks -

Nick

bss.patch (1.65 KB)

2

Is this an extension to what cctools' assembler provides or a missing
feature in MC?

3

I believe it’s a feature missing in MC - https://github.com/opensource-apple/cctools/blob/4da58fd2fc026317ed9e9ef1feabf21ed0bb7a81/cctools-836/as/i386.c line 539 adds support for the .bss directive if certain variables are defined, and mainline gas supports it on all ARM targets: https://sourceware.org/binutils/docs/as/ARM-Directives.html . Supporting the directive on all Darwin targets could be considered an extension though. Thanks -

4

LGTM

5

Thanks - how would I go about getting this committed?

Nick

6

I can commit it for you or you can apply for commit access.

http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

Cheers,
Rafael

7

Could you commit it? This is my first commit to LLVM so I’m not sure I need commit access yet. Thanks -