Adding title in HTML report

Hello,

I'm think it may be convenient to update the HTMLRewriter to support a <title> in the header.

When I read a static report result page, I have to scroll to the top of the page to find the file name. If we put the filename into the html title field, the browser will display it in the window title.

So I think we can update the HTMLRewriter, AddHeaderFooterInternalBuiltinCSS method to accept an optional title string.

void html::AddHeaderFooterInternalBuiltinCSS(Rewriter& R, unsigned FileID, const char *title = NULL)

But after, what is the recommanded way to compose the header.

will something like this be fine (using a ostringstream) ? I also attach a patch that implements this change.

html_title.diff (3.69 KB)

Applied:

http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20080707/006407.html

Thanks!