address space overloading patch broke the llvm-gcc build

Hi, I see this when building llvm-gcc on x86-32 linux:

xgcc -Bgcc/ -B/usr/local/gnat-llvm/i686-pc-linux-gnu/bin/ -B/usr/local/gnat-llvm/i686-pc-linux-gnu/lib/ -isystem /usr/local/gnat-llvm/i686-pc-linux-gnu/include -isystem /usr/local/gnat-llvm/i686-pc-linux-gnu/sys-include -DHAVE_CONFIG_H -I. -I../../../gcc-4.2.llvm/libgomp -I. -I../../../gcc-4.2.llvm/libgomp/config/linux/x86 -I../../../gcc-4.2.llvm/libgomp/config/linux -I../../../gcc-4.2.llvm/libgomp/config/posix -I../../../gcc-4.2.llvm/libgomp -Wall -Werror -ftls-model=initial-exec -march=i486 -pthread -mtune=i686 -O2 -g -O2 -MT critical.lo -MD -MP -MF .deps/critical.Tpo -c ../../../gcc-4.2.llvm/libgomp/critical.c -fPIC -DPIC -o .libs/critical.o
Overloaded intrinsic has incorrect suffix: '.i8'. It should be '.i8.p0i8'
i8 (i8*, i8)* @llvm.atomic.swap.i8
Broken module found, compilation aborted!
../../../gcc-4.2.llvm/libgomp/critical.c: In function 'GOMP_critical_end':
../../../gcc-4.2.llvm/libgomp/critical.c:44: internal compiler error: Aborted

So I guess your address space overloading patch broke llvm-gcc.

Ciao,

Duncan.

Hi,

Sorry for breakage, I'll look into this right now. I guess llvm-gcc doesn't use llvm tablegen results to help create intrinsic names.

   -- Mon Ping

Hi,

Sorry for breakage, I'll look into this right now. I guess llvm-gcc
doesn't use llvm tablegen results to help create intrinsic names.

  -- Mon Ping

It calls Intrinsic::getDeclaration.

Hi Dale,

Thanks, I see my bug now where I need to update.

   -- Mon Ping

I checked in the fix for the atomic names so GCC should build now. Sorry for the breaking the build.

   -- Mon Ping