Beginner: examples in `linalg` dialect reference are obsolete

Hi there,

I’m not sure whether this post is off-topic to this forum, but I just noticed that most examples in the linalg dialect reference documentation are obsolete based on the recent MLIR version (the one I’m using is ce23e54162edcb0de9b7af1f457229da0bbfe79d) on GitHub.

Most of them are syntactic problems, e.g., in the very first example,

#attrs = {args_in: 1, args_out: 1}

should be replaced by

#attrs = {args_in = 1, args_out=1}

I don’t know if fixing these minor problems are on someone’s TODO list atm, but if not, maybe I can create a patch for this? Just to make sure every code snippet in that doc can be directly thrown into mlir-opt without any hassle.

I’m still new to MLIR (finished-toy-tutorial-level), so I’m totally ok if this problem should be taken care of by a more senior member :slight_smile:

Best regards

Patches will be welcome! Thanks :slight_smile:
See here for the process and let us know if you have any other questions!

1 Like