[Bug 19818] New: Clean up unused variable warnings in MI code

Bug ID 19818
Summary Clean up unused variable warnings in MI code
Product lldb
Version unspecified
Hardware PC
OS All
Status NEW
Severity normal
Priority P
Component All Bugs
Assignee lldb-dev@cs.uiuc.edu
Reporter tfiala@google.com
Classification Unclassified

I'm seeing quite a few unused variable warnings on the Linux gcc-based build in
the MI code:

tools/lldb-mi/MICmdFactory.cpp: In member function ‘bool
CMICmdFactory::CmdCreate(const CMIUtilString&, const SMICmdData&,
CMICmdBase*&)’:
tools/lldb-mi/MICmdFactory.cpp:218:24: warning: unused variable ‘rMiCmd’
[-Wunused-variable]
  const CMIUtilString & rMiCmd( (*it).first );
tools/lldb-mi/MICmdInvoker.cpp: In member function ‘void
CMICmdInvoker::CmdDeleteAll()’:
tools/lldb-mi/MICmdInvoker.cpp:109:16: warning: unused variable ‘cmdId’
[-Wunused-variable]
   const MIuint cmdId( (*it).first );
                ^
tools/lldb-mi/MICmdInvoker.cpp:111:25: warning: unused variable ‘rCmdName’
[-Wunused-variable]
   const CMIUtilString & rCmdName( pCmd->GetCmdData().strMiCmd );
[73/90] Building CXX object
tools/lldb/tools/lldb-mi/CMakeFiles/lldb-mi.dir/MIDriver.cpp.o
tools/lldb-mi/MIDriverMgr.cpp: In member function ‘CMIDriverMgr::IDriver*
CMIDriverMgr::GetFirstMIDriver() const’:
tools/lldb-mi/MIDriverMgr.cpp:625:25: warning: unused variable ‘dvrId’
[-Wunused-variable]
   const CMIUtilString & dvrId = (*it).first;
                         ^
tools/lldb-mi/MIDriverMgr.cpp: In member function ‘CMIDriverMgr::IDriver*
CMIDriverMgr::GetFirstNonMIDriver() const’:
tools/lldb-mi/MIDriverMgr.cpp:654:25: warning: unused variable ‘dvrId’
[-Wunused-variable]
   const CMIUtilString & dvrId = (*it).first;
[74/90] Building CXX object
tools/lldb/tools/lldb-mi/CMakeFiles/lldb-mi.dir/MIDriverMain.cpp.o
[75/90] Building CXX object
tools/lldb/tools/lldb-mi/CMakeFiles/lldb-mi.dir/MIUtilFileStd.cpp.o
tools/lldb-mi/MICmdCmdData.cpp: In member function ‘virtual bool
CMICmdCmdDataEvaluateExpression::Execute()’:
tools/lldb-mi/MICmdCmdData.cpp:134:25: warning: unused variable ‘eValueType’
[-Wunused-variable]
   const lldb::ValueType eValueType = value.GetValueType();
                         ^
At global scope:
[76/90] Building CXX object
tools/lldb/tools/lldb-mi/CMakeFiles/lldb-mi.dir/MIUtilString.cpp.o
[77/90] Building CXX object
tools/lldb/tools/lldb-mi/CMakeFiles/lldb-mi.dir/MIUtilSetID.cpp.o
tools/lldb-mi/MICmdCmdTarget.cpp: In member function ‘virtual bool
CMICmdCmdTargetSelect::Execute()’:
tools/lldb-mi/MICmdCmdTarget.cpp:143:14: warning: unused variable ‘bOk’
[-Wunused-variable]
   const bool bOk = error.GetDescription( errMsg );
[enabled by default]
tools/lldb-mi/MICmdCmdBreak.cpp: In member function ‘virtual bool
CMICmdCmdBreakInsert::Execute()’:
tools/lldb-mi/MICmdCmdBreak.cpp:151:16: warning: unused variable ‘nSplits’
[-Wunused-variable]
   const MIuint nSplits = m_brkName.Split( cColon, vecFileAndLocation );
                ^
tools/lldb-mi/MICmdCmdBreak.cpp:142:7: warning: unused variable ‘bIsFileLine’
[-Wunused-variable]
  bool bIsFileLine = false;
       ^
tools/lldb-mi/MICmdCmdBreak.cpp:143:7: warning: unused variable ‘bIsFileFn’
[-Wunused-variable]
  bool bIsFileFn = false;
       ^
tools/lldb-mi/MICmdCmdBreak.cpp: In member function ‘virtual bool
CMICmdCmdBreakInsert::Acknowledge()’:
tools/lldb-mi/MICmdCmdBreak.cpp:252:15: warning: unused variable ‘pModule’
[-Wunused-variable]
  const char * pModule = rModule.IsValid() ?
rModule.GetFileSpec().GetFilename() : pUnkwn;

...  (quite a few more)

labath@google.com changed bug 19818

What | Removed | Added |

  • | - | - |
    Status | NEW | RESOLVED |
    CC | | labath@google.com |
    Resolution | — | FIXED |

Comment # 1 on bug 19818 from labath@google.com

appears to be fixed now.