[Bug 28939] New: test infra: convert pexpect errors into failures

Bug ID 28939
Summary test infra: convert pexpect errors into failures
Product lldb
Version unspecified
Hardware PC
OS All
Status NEW
Severity normal
Priority P
Component All Bugs
Assignee lldb-dev@lists.llvm.org
Reporter todd.fiala@gmail.com
CC llvm-bugs@lists.llvm.org
Classification Unclassified

When LLDB runs pexpect tests, and the pexpect condition does not match
(typically due to a pexpect timeout), this shows up as a test error.  This is
because unittest sees an exception thrown that isn't one of its assert
exceptions.

In reality, the pexpect timeout is a failure - something didn't match.  It
isn't an error, which is reserved to indicate something totally off the rails
went wrong.  A non-match is a failure, not an off-the-rails error.

We should be able to catch pexpect timeouts and adapt them to show up as
failures.