[Bug 34772] New: Fix all remaining testsuite failures with target.experimental.use-modern-type-lookup

Bug ID 34772
Summary Fix all remaining testsuite failures with target.experimental.use-modern-type-lookup
Product lldb
Version unspecified
Hardware PC
OS All
Status NEW
Severity enhancement
Priority P
Component All Bugs
Assignee lldb-dev@lists.llvm.org
Reporter scallanan@apple.com
CC llvm-bugs@lists.llvm.org

Currently target.experimental.use-modern-type-lookup is defaulted to off.

There are several reasons it should be on:

 - ExternalASTMerger is shared code which will allow other clients to complete
types from multiple sources, as LLDB does.

 - This will allow us to remove the ClangASTImporter, a large container of
state which can go bad over time.

 - ExternalASTMerger has much more complete unit testing; I believe the
remaining testsuite failures are because of as-yet-incomplete LLDB use of it.

It's possible to run the testsuite with use-modern-type-lookup enabled, by
changing g_experimental_properties in Target.cpp to make it default-on.  The
resulting testsuite failures need to be fixed and the setting should then be
enabled.