[Bug 36630] New: LLDB SB API headers not installed anymore since r309021

Bug ID 36630
Summary LLDB SB API headers not installed anymore since r309021
Product lldb
Version unspecified
Hardware PC
OS Linux
Status NEW
Severity normal
Priority P
Component All Bugs
Assignee lldb-dev@lists.llvm.org
Reporter tschelle@redhat.com
CC llvm-bugs@lists.llvm.org

Since r309021 the LLDB SB API headers (e.g /usr/include/lldb/API/LLDB.h) are
not installed anymore. Previously they were installed by default.

Looking at the commit that introduced the regression it seems this is coming
from some accidentally committed changes (at least the commit message doesn't
mention anything about the excludes).

The change landed a couple of days after 5.0 was branched so this affects the
6.0 release.

commit 10e79c4459e0a6002edf2fea14432c293c5d509f
Author: Chris Bieneman <[beanz@apple.com](mailto:beanz@apple.com)>

    [CMake] Cleanup unnecessary definition

    This is only used in one file, and we already set it correctly on that
file, so we don't need to set this everywhere.   

    git-svn-id: [https://llvm.org/svn/llvm-project/lldb/trunk@309021](https://llvm.org/svn/llvm-project/lldb/trunk@309021)

diff --git a/cmake/modules/LLDBConfig.cmake b/cmake/modules/LLDBConfig.cmake
index 726552675..71820c965 100644
--- a/cmake/modules/LLDBConfig.cmake
+++ b/cmake/modules/LLDBConfig.cmake
@@ -22,10 +22,6 @@ elseif(IOS)

-  add_definitions(-DNO_XPC_SERVICES)

labath@google.com changed bug 36630

What | Removed | Added |

Comment # 1 on bug 36630 from labath@google.com

I ran into this last month as well, but follow up on it yet. I'll put up a
patch for that soon.