[Bug 45981] New: StringRef::getAsInteger doesn't support "+1"

Bug ID 45981
Summary StringRef::getAsInteger doesn’t support “+1”
Product lldb
Version unspecified
Hardware PC
OS All
Status NEW
Severity enhancement
Priority P
Component All Bugs
Assignee lldb-dev@lists.llvm.org
Reporter jingham@apple.com
CC jdevlieghere@apple.com, llvm-bugs@lists.llvm.org

(lldb) set set interpreter.expand-regex-aliases 1
(lldb) jump +1
thread jump --by +1
error: invalid line offset: '+1'.

And indeed:

(lldb) thread jump --by +1
error: invalid line offset: '+1'.

The option parser calls:

option_arg.getAsInteger(0, m_line_offset);

where m_line_offset it the storage for the integer read in.  Either
StringRef::getAsInteger should support this, or we should strip off the leading
+.