Can we nuke SetUpBuildDumpLog?

Clang Frontend
1

Hi Chris, I noticed that in r69386 you introduced a "build dump"
functionality. Is that still used? if not I'd like to nuke it because
it is causing argc/argv to leak down into the library code. E.g.
argc/argv are required arguments to
CompilerInstance::createDiagnostics solely for the purpose of being
passed to SetUpBuildDumpLog().

-- Sean Silva

2

I don't remember adding this, and with svn down I can't see the commit message.

-Chris

3

To help the discussion keep moving:

    implement a new clang-cc option -dump-build-information=filename which cause
    compiler to dump random stuff from the build into the file. Right now this
    amounts to dumping command line arguments and diagnostics to the file.
    
    The idea is that you can set an envvar, do a world build of an OS, then grep
    through all the logs for interesting things or something.
    
    Daniel, please wire the driver up to do something with this.

4

To help the discussion keep moving:

   implement a new clang-cc option -dump-build-information=filename which cause
   compiler to dump random stuff from the build into the file. Right now this
   amounts to dumping command line arguments and diagnostics to the file.

   The idea is that you can set an envvar, do a world build of an OS, then grep
   through all the logs for interesting things or something.

   Daniel, please wire the driver up to do something with this.

I don't remember that at all, and have no attachment to it. Daniel, do you remember what this was about, and whether it is used at all?

-Chris

5

To help the discussion keep moving:

  implement a new clang-cc option -dump-build-information=filename which cause
  compiler to dump random stuff from the build into the file. Right now this
  amounts to dumping command line arguments and diagnostics to the file.

  The idea is that you can set an envvar, do a world build of an OS, then grep
  through all the logs for interesting things or something.

  Daniel, please wire the driver up to do something with this.

I don't remember that at all, and have no attachment to it. Daniel, do you remember what this was about, and whether it is used at all?

It's not used, it can be removed. I think I asked for it at some point but never wrote anything else that used it.

- Daniel

6

I finally got around to doing this in r172945.

-- Sean Silva