CharacterLiteral get/set location.

Clang Frontend
1

Class CharacterLiteral has the following public methods, which are inconsistently named:

   SourceLocation getLoc() const { return Loc; }
   void setLocation(SourceLocation Location) { Loc = Location; }

The attached patch makes these names consistent.

Cheers,
Enea Zaffanella.

Char_Location.patch (1.07 KB)

2

Class CharacterLiteral has the following public methods, which are inconsistently named:

SourceLocation getLoc() const { return Loc; }
void setLocation(SourceLocation Location) { Loc = Location; }

The attached patch makes these names consistent.

Looks great, please attach the patch as an attachment (instead of inline) to make it easier to apply. Thanks!

-Chris

3

See directions 'For Thuderbird users' here:

http://llvm.org/docs/DeveloperPolicy.html#patches

— Gordon

4

Chris Lattner wrote:

Class CharacterLiteral has the following public methods, which are inconsistently named:

SourceLocation getLoc() const { return Loc; }
void setLocation(SourceLocation Location) { Loc = Location; }

The attached patch makes these names consistent.

Looks great, please attach the patch as an attachment (instead of inline) to make it easier to apply. Thanks!

-Chris

Second attempt, after playing with mailer options.

Cheers,
Enea.

Char_Location.patch (1.07 KB)

5

Thanks, applied as r79924!

-Chris