[Clang-tidy] applying fixes multiple times on same file

Clang Frontend
1

Hi,
So After running clang-tidy it did change some warnings very well, but some of them were fixed multiple times like:

  • Event(const std::shared_ptr &record);
  • explicit explicit Event(const std::shared_ptr &record);

-} // ga
+} // namespace gamespace ga

-}
+} // namespace ga // namespace ga // namespace ga // namespace ga

  • RecordStreamga::Event getRecordStream() override override;

Is it known feature? Am I doing something wrong?

Piotr

2

Bump
I can also say that this thing takes place in header files.

Piotr

3

Are you trying to run it on more than one cpp file at a time?

I think it precesses all the files first and comes up with a big list of changes, then applies them. Which means you could get duplicate changes when processing multiple cpp files that include the same headers.

I just do them one at a time.

4

Ok thanks Don. I think it would be good to provide that information in documentation.

5

Ok thanks Don. I think it would be good to provide that information in
documentation.

Heya,

that's why there's the 'run-clang-tidy' python script [1] as part of clang-
tidy.

It does
- Parallelize the clang-tidy invocations
- Records changes-to-be-made (via `clang-tidy -export-fixes`)
- And only when joining the subprocesses: Applies the changes
  (using clang-apply-replacements)

Hope that helps,

Cheers,
Kevin

[1] https://llvm.org/svn/llvm-project/clang-tools-extra/trunk/clang-tidy/tool/
run-clang-tidy.py