[clang-tools-extra] r179103 - Fix UseNullptr fails to replace c-style explicit cast in a return statement

These are compilation failures from simply compiling a lit test before the first transform is applied. This failure doesn't seem to have anything to do with the Migrator, and more to do with the nature of the test. You should get the same result just using clang++ -fsyntax-only. On Linux some of these errors are warnings caused by -Wnon-literal-null-conversion. I've never seen this test fail on windows and it hasn't changed in some time. Looking back through the build history of this builder this test was passing as of http://bb.pgr.jp/builders/ninja-clang-i686-msc17-R/builds/2055. My guess something changed in clang in how it handles this kind of code.

Does clang treat warnings/errors differently on windows than on Linux? Did something change recently in clang that might cause these errors to pop up on windows. I don't see them in Linux with a clean build of llvm/clang/Migrator.

I think microsoft extensions are enabled by default, but I don't know
of any other difference.

Cheers,
Rafael

I think microsoft extensions are enabled by default, but I don't know
of any other difference.

And it uses c++11 by default.

This issue should be fixed in r183983.

Cheers,
Rafael

The Migrator requires that C++11 be enabled by the command line args to compile the code. Many lit tests haven't been updated to reflect this. I see by turning on C++11 in Linux breaks the test in the same way. I'll log a bug to update/fix the lit tests to be initially compilable with C++11.