[Classic flang] RFC: Adding release_110 branch to flang-compiler/classic-flang-llvm-project

Michal_Paszta · January 5, 2021, 2:39pm

Hello,

In cooperation with Richard Barton, Bryan Chan and Andrzej Warzyński I have created a candidate release_110 branch in classic-flang-llvm-project (https://github.com/michalpasztamobica/classic-flang-llvm-project/tree/release_110):

The release/11.x branch of llvm-project (https://github.com/llvm/llvm-project/tree/release/11.x) has been pulled to the classic-flang-llvm-project.
All commits from ef32c61 from release_100 have been cherry-picked and all merge conflicts resolved.
I made sure that flang project’s master branch builds and passes all tests with the new branch in classic-flang-llvm-project (many thanks to Andrzej for his help with this).

We would welcome any comments and suggestions from the Community before the branch is pulled from the fork to flang-compiler/classic-flang-llvm-project. Please, let us know your thoughts in this mailing list thread, as comments to code on github or on “flang-compiler” Slack channel.

Thank you and best regards,

Mobica is a global software services company, delivering and enabling technologies that transform business outcomes for the leading brands in Automotive, Silicon, FinTech, Media and Telecoms. Headquartered in Wilmslow UK with offices across Europe and the US, our established technical and delivery excellence in high quality software engineering drives success for our multinational customers on every continent, every day.
Find out more at Mobica.com

Mobica Limited is a limited company registered in England and Wales with registered number 05169596 and VAT registered number 223837508. Our registered office is at Crown House, Manchester Road, Wilmslow, Cheshire, SK9 1BH, UK.
This message is intended solely for the addressee(s) and may contain confidential information.
If you have received this message in error, please send it back to us, and immediately and permanently delete it.
Do not use, copy or disclose the information contained in this message or in any attachment.
Mobica complies with all requirements of GDPR and other relevant data protection law. You can view our Privacy Policy at https://mobica.com/privacy-policy/

Vinay_Madhusudan · January 22, 2021, 6:30am

Hi,

There are issues in compiling multiple SPEC CPU 2017 Fotran benchmarks while using release_110 branch in the mentioned github repository. Are you planning to support it?

The issues we identified so far are related to :

sincos() optimization in flang / LLVM 11.
Link errors for few fortran runtime functions.

Thanks,
Vinay.

Michal_Paszta · January 22, 2021, 8:16am

Hi Vinay,

Thanks a lot for taking time to check this and let us know!
The branch_11x was already pulled to the origin repo, just 15 minutes before your e-mail.

Are the issues you mention a regression compared to branch_100 of classic-flang-llvm-project? Do you know if f18 (https://github.com/llvm/llvm-project/tree/release/11.x/flang) does any better?

If these are important, perhaps you could report them as issues in the github repository (https://github.com/flang-compiler/classic-flang-llvm-project/issues)? I do not have access to the SPEC benchmark and I think much of the community might not have it, so it would be great if you could provide some minimal reproducers.

I will try to determine if we have the bandwidth to work on them and let you know by Monday.

Best regards,

Michał Paszta
Senior Consultant / Senior Group Manager

Mobica Ltd.
Address: Skierniewicka 10a, 01-230 Warszawa

Hi,

There are issues in compiling multiple SPEC CPU 2017 Fotran benchmarks while using release_110 branch in the mentioned github repository. Are you planning to support it?

The issues we identified so far are related to :

sincos() optimization in flang / LLVM 11.

Link errors for few fortran runtime functions.

Thanks,
Vinay.

Hello,

In cooperation with Richard Barton, Bryan Chan and Andrzej Warzyński I have created a candidate release_110 branch in classic-flang-llvm-project (https://github.com/michalpasztamobica/classic-flang-llvm-project/tree/release_110):

The release/11.x branch of llvm-project (https://github.com/llvm/llvm-project/tree/release/11.x) has been pulled to the classic-flang-llvm-project.

All commits from ef32c61 from release_100 have been cherry-picked and all merge conflicts resolved.

I made sure that flang project’s master branch builds and passes all tests with the new branch in classic-flang-llvm-project (many thanks to Andrzej for his help with this).

We would welcome any comments and suggestions from the Community before the branch is pulled from the fork to flang-compiler/classic-flang-llvm-project. Please, let us know your thoughts in this mailing list thread, as comments to code on github or on “flang-compiler” Slack channel.

Thank you and best regards,

Michał Paszta
Senior Consultant / Senior Group Manager

Mobica Ltd.
Address: Skierniewicka 10a, 01-230 Warszawa

Mobica is a global software services company, delivering and enabling technologies that transform business outcomes for the leading brands in Automotive, Silicon, FinTech, Media and Telecoms. Headquartered in Wilmslow UK with offices across Europe and the US, our established technical and delivery excellence in high quality software engineering drives success for our multinational customers on every continent, every day.
Find out more at Mobica.com

Mobica Limited is a limited company registered in England and Wales with registered number 05169596 and VAT registered number 223837508. Our registered office is at Crown House, Manchester Road, Wilmslow, Cheshire, SK9 1BH, UK.
This message is intended solely for the addressee(s) and may contain confidential information.
If you have received this message in error, please send it back to us, and immediately and permanently delete it.
Do not use, copy or disclose the information contained in this message or in any attachment.
Mobica complies with all requirements of GDPR and other relevant data protection law. You can view our Privacy Policy at https://mobica.com/privacy-policy/

flang-dev mailing list
flang-dev@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/flang-dev

Mobica is a global software services company, delivering and enabling technologies that transform business outcomes for the leading brands in Automotive, Silicon, FinTech, Media and Telecoms. Headquartered in Wilmslow UK with offices across Europe and the US, our established technical and delivery excellence in high quality software engineering drives success for our multinational customers on every continent, every day.
Find out more at Mobica.com

Mobica Limited is a limited company registered in England and Wales with registered number 05169596 and VAT registered number 223837508. Our registered office is at Crown House, Manchester Road, Wilmslow, Cheshire, SK9 1BH, UK.
This message is intended solely for the addressee(s) and may contain confidential information.
If you have received this message in error, please send it back to us, and immediately and permanently delete it.
Do not use, copy or disclose the information contained in this message or in any attachment.
Mobica complies with all requirements of GDPR and other relevant data protection law. You can view our Privacy Policy at https://mobica.com/privacy-policy/

Vinay_Madhusudan · January 22, 2021, 9:45am

Hi Michal,

I have created an issue ( https://github.com/flang-compiler/classic-flang-llvm-project/issues/11 ) with a test case.

Are the issues you mention a regression compared to branch_100 of classic-flang-llvm-project?
Do you mean https://github.com/flang-compiler/classic-flang-llvm-project/tree/release_100 ? It was working fine for this branch.

Do you know if f18 (https://github.com/llvm/llvm-project/tree/release/11.x/flang) does any better?
I haven’t checked.

Thanks,
Vinay

Michal_Paszta · January 22, 2021, 12:19pm

Hi Vinay,

Thanks a lot for the report.
Right now we will not actively work on this issue and I cannot give any timeline for this at the moment.
However, for future reference it would also be good if you could give more details (either here or in a new issue report in the repo) for the linker errors you were referring to in your previous email.

Again - thank you for reporting this and sorry we will not be able to take this up. You are most welcome to submit patches to the repository if you manage to solve them.

Best regards,

Hi Michal,

I have created an issue ( https://github.com/flang-compiler/classic-flang-llvm-project/issues/11 ) with a test case.

Are the issues you mention a regression compared to branch_100 of classic-flang-llvm-project?
Do you mean https://github.com/flang-compiler/classic-flang-llvm-project/tree/release_100 ? It was working fine for this branch.

Do you know if f18 (https://github.com/llvm/llvm-project/tree/release/11.x/flang) does any better?
I haven’t checked.

Thanks,
Vinay

Hi Vinay,

Thanks a lot for taking time to check this and let us know!
The branch_11x was already pulled to the origin repo, just 15 minutes before your e-mail.

Are the issues you mention a regression compared to branch_100 of classic-flang-llvm-project? Do you know if f18 (https://github.com/llvm/llvm-project/tree/release/11.x/flang) does any better?

If these are important, perhaps you could report them as issues in the github repository (https://github.com/flang-compiler/classic-flang-llvm-project/issues)? I do not have access to the SPEC benchmark and I think much of the community might not have it, so it would be great if you could provide some minimal reproducers.

I will try to determine if we have the bandwidth to work on them and let you know by Monday.

Best regards,

Michał Paszta
Senior Consultant / Senior Group Manager

Mobica Ltd.
Address: Skierniewicka 10a, 01-230 Warszawa

Hi,

There are issues in compiling multiple SPEC CPU 2017 Fotran benchmarks while using release_110 branch in the mentioned github repository. Are you planning to support it?

The issues we identified so far are related to :

sincos() optimization in flang / LLVM 11.

Link errors for few fortran runtime functions.

Thanks,
Vinay.

Hello,

In cooperation with Richard Barton, Bryan Chan and Andrzej Warzyński I have created a candidate release_110 branch in classic-flang-llvm-project (https://github.com/michalpasztamobica/classic-flang-llvm-project/tree/release_110):

The release/11.x branch of llvm-project (https://github.com/llvm/llvm-project/tree/release/11.x) has been pulled to the classic-flang-llvm-project.

All commits from ef32c61 from release_100 have been cherry-picked and all merge conflicts resolved.

I made sure that flang project’s master branch builds and passes all tests with the new branch in classic-flang-llvm-project (many thanks to Andrzej for his help with this).

We would welcome any comments and suggestions from the Community before the branch is pulled from the fork to flang-compiler/classic-flang-llvm-project. Please, let us know your thoughts in this mailing list thread, as comments to code on github or on “flang-compiler” Slack channel.

Thank you and best regards,

Michał Paszta
Senior Consultant / Senior Group Manager

Mobica Ltd.
Address: Skierniewicka 10a, 01-230 Warszawa

Mobica is a global software services company, delivering and enabling technologies that transform business outcomes for the leading brands in Automotive, Silicon, FinTech, Media and Telecoms. Headquartered in Wilmslow UK with offices across Europe and the US, our established technical and delivery excellence in high quality software engineering drives success for our multinational customers on every continent, every day.
Find out more at Mobica.com

Mobica Limited is a limited company registered in England and Wales with registered number 05169596 and VAT registered number 223837508. Our registered office is at Crown House, Manchester Road, Wilmslow, Cheshire, SK9 1BH, UK.
This message is intended solely for the addressee(s) and may contain confidential information.
If you have received this message in error, please send it back to us, and immediately and permanently delete it.
Do not use, copy or disclose the information contained in this message or in any attachment.
Mobica complies with all requirements of GDPR and other relevant data protection law. You can view our Privacy Policy at https://mobica.com/privacy-policy/

flang-dev mailing list
flang-dev@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/flang-dev

Mobica is a global software services company, delivering and enabling technologies that transform business outcomes for the leading brands in Automotive, Silicon, FinTech, Media and Telecoms. Headquartered in Wilmslow UK with offices across Europe and the US, our established technical and delivery excellence in high quality software engineering drives success for our multinational customers on every continent, every day.
Find out more at Mobica.com

Mobica Limited is a limited company registered in England and Wales with registered number 05169596 and VAT registered number 223837508. Our registered office is at Crown House, Manchester Road, Wilmslow, Cheshire, SK9 1BH, UK.
This message is intended solely for the addressee(s) and may contain confidential information.
If you have received this message in error, please send it back to us, and immediately and permanently delete it.
Do not use, copy or disclose the information contained in this message or in any attachment.
Mobica complies with all requirements of GDPR and other relevant data protection law. You can view our Privacy Policy at https://mobica.com/privacy-policy/

Mobica is a global software services company, delivering and enabling technologies that transform business outcomes for the leading brands in Automotive, Silicon, FinTech, Media and Telecoms. Headquartered in Wilmslow UK with offices across Europe and the US, our established technical and delivery excellence in high quality software engineering drives success for our multinational customers on every continent, every day.
Find out more at Mobica.com

Mobica Limited is a limited company registered in England and Wales with registered number 05169596 and VAT registered number 223837508. Our registered office is at Crown House, Manchester Road, Wilmslow, Cheshire, SK9 1BH, UK.
This message is intended solely for the addressee(s) and may contain confidential information.
If you have received this message in error, please send it back to us, and immediately and permanently delete it.
Do not use, copy or disclose the information contained in this message or in any attachment.
Mobica complies with all requirements of GDPR and other relevant data protection law. You can view our Privacy Policy at https://mobica.com/privacy-policy/