Code owner nomination for cpp11-migrate

I'd like to nominate Edwin Vane as the code owner for cpp11-migrate. Edwin's part of the team that's developing this tool full-time, and has made nearly all commits in it so far (excluding the previous work on loop-convert).

I suppose we don't really have a precedent for code owners in extra, but we need one for cpp11-migrate as we now have several folks contributing steadily to it.

Stefanus

Having heard no objection, I'll take that as approval and add a code
owners file to extra tomorrow unless I hear otherwise.

Thanks!

Stefanus

Having heard no objection, I'll take that as approval and add a code
owners file to extra tomorrow unless I hear otherwise.

Sounds good to me.

Having heard no objection, I’ll take that as approval and add a code
owners file to extra tomorrow unless I hear otherwise.

I object to this approach. Code owners in the LLVM community have always been explicitly approved by the existing code owners, and that should continue. We love post-commit review, but not to CODE_OWNERS.TXT :slight_smile:

  • Doug

Having heard no objection, I'll take that as approval and add a code
owners file to extra tomorrow unless I hear otherwise.

I object to this approach. Code owners in the LLVM community have always been explicitly approved by the existing code owners, and that should continue. We love post-commit review, but not to CODE_OWNERS.TXT :slight_smile:

- Doug

Thanks – makes sense. That's exactly why I wrote the message since I didn't hear anything in the first place :).

So, would that fall to you, given that there's no code owner for "extra" that I'm aware of? Are you OK with this?

Stefanus

From: Douglas Gregor <dgregor@apple.com<mailto:dgregor@apple.com>>
Date: Wednesday, 13 March, 2013 1:24 PM
To: Stefanus Du Toit <stefanus.du.toit@intel.com<mailto:stefanus.du.toit@intel.com>>
Cc: "cfe-dev@cs.uiuc.edu<mailto:cfe-dev@cs.uiuc.edu>" <cfe-dev@cs.uiuc.edu<mailto:cfe-dev@cs.uiuc.edu>>
Subject: Re: [cfe-dev] Code owner nomination for cpp11-migrate

Having heard no objection, I'll take that as approval and add a code
owners file to extra tomorrow unless I hear otherwise.

I object to this approach. Code owners in the LLVM community have always been explicitly approved by the existing code owners, and that should continue. We love post-commit review, but not to CODE_OWNERS.TXT :slight_smile:

- Doug

Thanks – makes sense. That's exactly why I wrote the message since I didn't hear anything in the first place :).

So, would that fall to you, given that there's no code owner for "extra" that I'm aware of? Are you OK with this?

Yes and yes. Thank you, Edwin!

  - Doug