[Code Review] Reminder about links in code & commit messages

[vsapsai]

@AaronBallman

Asking questions itself isn’t the burden; we do that all the time, but those are targeted questions to people you think may know the answer and can respond. In the case of rdar links, it’s targeting arbitrary people based on what company they work for to solicit private information they may not be comfortable with or allowed to share. So it’s a slightly different situation than your typical “do you know more about this?” kind of question.

What is preventing from asking “do you know more about this?” a person who put there a rdar link? Sorry, I understand it sounds snarky, but I want to understand the problem and maybe there are better ways to address it.

@AaronBallman

When there is a rdar link and no other surrounding context, you can’t make that same judgement call without wondering “does this break a downstream in ways I don’t understand?”

I understand this feels like extra thing to worry about and an extra work. But I want to note that those tests capture observable clang behavior. And any clang user can rely on it. Changing such behavior would affect not only users of Apple-vended clang but all users of clang and can break any of them. I see those links as a source of more information to evaluate how disruptive your change is but accept that’s not the case for everyone.