constness of argv in CompilerInstance

Clang Frontend
1

Hi,

can the constness screw on CompilerInstance's argv be tightened up a
bit, like in the attached patch? It would allow us to use fake argv
string literals to talk to the CompilerInstance, and it signals that
CompilerInstance is not modifying argv.

Let me know if it's okay to commit (if I still have checkin permissions,
that is...)

Cheers, Axel.

CompilerInstance_Argv_const.diff (2.17 KB)

2

Hi,

and if you want: spread the constness joy to CompilerInvocation +
ArgList + OptTable. Patch does not include changes to CompilerInstance

Cheers, Axel.

CompilerInvocation_Argv_const.diff (3.95 KB)

3

LGTM, assuming it builds of course. :slight_smile:

Please apply!

- Daniel

4

LGTM, please apply!

- Daniel