"correct" way to implement a call

Project Infrastructure LLVM Dev List Archives
1

Currently, Alpha, PowerPC and X86 implement LowerFORMAL_ARGUMENTS.
PowerPC and X86 lower ISD::CALL in LowerOperation. Alpha implements
custom select. What is the preferred way to implement this?

Thanks,
Rafael

2

The preferred way to handle this is to implement it in XXXTargetLowering::LowerOperation like PPC/X86/Alpha do.

-Chris

3

Currently, Alpha, PowerPC and X86 implement LowerFORMAL_ARGUMENTS.
PowerPC and X86 lower ISD::CALL in LowerOperation. Alpha implements
custom select. What is the preferred way to implement this?

The custom select is because nodes with variable number of arguments (as
needed to lower ISD::CALL) didn't use to work. I've been waiting until
that is fixed to lower calls rather than custom select them. I have a
patch to do so sitting around, which I might get around to applying
since I think the variable arguments thing is fixed.

Andrew