Cross compiler build fix [Important]

Runtimes OpenMP
1

I sent a patch before that removed unnecessary copies and it was
rejected without a 2nd review. I'm attaching a slightly revised
approach which is hopefully ok for the Intel people. I realize I may
be the only one currently doing cross compiles of the library, but I
feel strongly this is important to do in a clean way. (source and
build dir seperate)

openmp.patch (1.58 KB)

2

*bump* the other patch was sent after my other one and hasn't been
reviewed. It should be trivial and is important to our cross compiler
buildbot.

Thanks

3

The one problem we have is that the testsuite expects libiomp5.so and omp.h to be in the openmp/runtime/exports/ directory. Is it ok if we add something like -DLIBIOMP_NO_EXPORTS=true?

-- Johnny

4

Yeah that works - I just need a way to disable this.

The testsuite should also be fixed to not depend on this. Since
apparently the lib name may be changing and imho depending on it like
this isn't clean.

The testsuite should ideally take a parameter - -DPATH_TO_OMP_RUNTIME
If we roll with a name change - it should pull the same variable as
what was used in my patch from the other day.

5

I think this patch will work. It offers a new option -DLIBIOMP_COPY_EXPORTS=true(default)|false
If you specify "false", then absolutely no copying is done anywhere after the library is built.

This patch applies on top of this change:
1fd47b8 Change some text areas from saying Intel(R) OpenMP runtime library to LLVM OpenMP runtime library.

-- Johnny

cross_compile_support.patch (8.96 KB)

6

Oops... I forgot to pull the latest changes before making the patch file. I will create a new one that applies on the latest snapshot. Sorry about that.

-- Johnny

7

This the same patch but applies on top of:
41ab51f patch to allow lib name at configure time (from C.Bergstrom)

-- Johnny

cross_compile_support.patch (8.96 KB)