Diagnostics not restored when disabled from within PCH

Hi all,

I just found that diagnostics that are temporarily disabled (using "#pragma clang diagnostic push/pop") from within precompiled headers are not re-enabled in the including file. Find attached a patch that extends the existing PCH-diagnostics-test to also test for this.

I'd be happy if someone could take care of this.

Cheers,
Matthias

test_diagnostics_restored.patch (956 Bytes)

Hi all,

I just found that diagnostics that are temporarily disabled (using "#pragma clang diagnostic push/pop") from within precompiled headers are not re-enabled in the including file. Find attached a patch that extends the existing PCH-diagnostics-test to also test for this.

I'd be happy if someone could take care of this.

Thanks for the test case!
Could you please file a bug report in bugzilla ?

-Argyrios

Done. Find the bug at http://llvm.org/bugs/show_bug.cgi?id=14181

Cheers,
Matthias