DirectoryWatcher causing build failures on Redhat linux with kernel version 2.6.32

Hi Jan,

our builds have been failing on Redhat linux kernel version 2.6.32 with the following error:

**2019.07.15 11:10:28**  ../llvm/tools/clang/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp:335:47: error: 'IN_EXCL_UNLINK' was not declared in this scope
**2019.07.15 11:10:28**         IN_CREATE | IN_DELETE | IN_DELETE_SELF | IN_EXCL_UNLINK | IN_MODIFY |

this is because of the patch https://reviews.llvm.org/rG77dd8a79286d2fff94c765f787d7f7debb2a10c4 which adds this code in. We build on a platform that uses the linux kernel version 2.6.32 which doesn’t have the IN_EXCL_UNLINK feature, could you please take a look ?

Thanks,

Ranjeet

Hi,

Same thing for me, as I described here:

http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20190708/279184.html

I think the problem is that the patch assumes that if sys/inotify.h
exists, then IN_EXCL_UNLINK is defined in it.

But I think that there are old versions of inotify.h where
IN_EXCL_UNLINK isn't defined.

/Mikael

Hi,

Same thing for me, as I described here:

http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20190708/279184.html

I think the problem is that the patch assumes that if sys/inotify.h
exists, then IN_EXCL_UNLINK is defined in it.

But I think that there are old versions of inotify.h where
IN_EXCL_UNLINK isn't defined.

Could you file a bug for this and cc me.

Thanks,
Tom

Hi,

Same thing for me, as I described here:

http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20190708/279184.html

I think the problem is that the patch assumes that if sys/inotify.h
exists, then IN_EXCL_UNLINK is defined in it.

But I think that there are old versions of inotify.h where
IN_EXCL_UNLINK isn't defined.

Could you file a bug for this and cc me.

Jan already fixed the problem in r366152.

Still want a bug on it?

/Mikael

Hi,

Same thing for me, as I described here:

http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20190708/279184.html

I think the problem is that the patch assumes that if sys/inotify.h
exists, then IN_EXCL_UNLINK is defined in it.

But I think that there are old versions of inotify.h where
IN_EXCL_UNLINK isn't defined.

Could you file a bug for this and cc me.

Jan already fixed the problem in r366152.

Still want a bug on it?

No, not any more. I just wanted to make sure it was tracked so it was
fixed before the 9.0.0 release, but the branch date isn't until Wednesday,
so the fix made it in time.

-Tom