Documenting community norms around reverts

I’ve posted a patch to document our norms around reverts. I was recently surprised to not find anything in this spirit. A lot of newcomers find our norms a bit odd, so having this explicitly spelled out seems very worthwhile.

I tried to stick to stuff that is uncontroversial in the community. If you see something here that less than 90+% of the community would agree with, please point it out. I’ll remove it for now, and possibly return to individual points if warranted in future reviews.

Philip

p.s. Draft text follows, but please make detailed wording suggestions on the review.

Reverts

Thanks for writing this up, I really like this text. Somehow I feel like it captures a collaborative spirit.

I'd like to see some wording to make sure flagging by buildbot is
actually somewhat logically related to that commit. We've had enough
issues with both flacky bots and the general 20 pages blame list that I
believe it is worth mentioning.

Joerg

I tried to stick to stuff that is uncontroversial in the community. If you
see something here that less than 90+% of the community would agree with,
please point it out. I'll remove it for now, and possibly return to
individual points if warranted in future reviews.

I'd like to see some wording to make sure flagging by buildbot is
actually somewhat logically related to that commit. We've had enough
issues with both flacky bots and the general 20 pages blame list that I
believe it is worth mentioning.

The current wording is: "If you break a buildbot in a way which can't be quickly fixed, please revert."

This to me seems to include the notion that you should only act on a build bot you break. (i.e. not some random email) I've also added a general carve out about guidelines not being hard and fast rules in the expectation section.

I would prefer to not go into build bots further in this patch. Build bots are described elsewhere in the docs, and the flaky bit deserves attention as it's own primary topic. I'd prefer to avoid commingling.

Once we have a section on flaky build bots, linking the word "break" above to that section seems like a good idea.

That okay with you?