Hi,
For example, https://reviews.llvm.org/rGdab999d54f39af3ebb6a23e850dbc9742016fac8 looks like an SVN commit, and I did not find its review history from Phabricator.
It also mentions rdar://19040716. Is this link still valid to access?
Thank you,
Not all patches are reviewed in Phabricator - the LLVM mailing list is
still the source of truth for review discussions. Here's the review
thread for that commit:
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20150105/251381.html
- back in the day, before Phabricator was used at all (& this is still
a valid, though less-used strategy), email threads on llvm-commits
would review the patch, then once the patch was committed a follow-up
email to the original thread would mention the revision that was
committed with the results of the review. I don't know of an effective
way to search the mailing list archive short of having subscribed to
the mailing list and kept all the email... but if you happen to have,
when you search for "r226592" you'll find the original commit email
and the original review thread.
rdar://*** is an Apple-internal bug tracker link. It's not useful to
anyone outside of Apple. (there's some debate about whether it's
acceptable to put these kinds of internal-only information in public
communications/bugs/commits - but in any case, even if they're
included, all the publicly necessary context should be rendered in the
public communications - commit messages, bug descriptions, etc)
Hi,
For example,
https://reviews.llvm.org/rGdab999d54f39af3ebb6a23e850dbc9742016fac8 looks
like an SVN commit, and I did not find its review history from Phabricator.
Not everything which was committed was reviewed in Phabricator. Things reviewed in Phabricator will (in 99% of the cases) contain "Differential Revision: ...".
Example:
https://reviews.llvm.org/rG8f0129c407395d01fd3a50b6f00ca480033d8a43
It has a link to https://reviews.llvm.org/D33015
From there you can also find links to the previous SVN revision(s), e.g. https://reviews.llvm.org/rL302569
It also mentions rdar://19040716. Is this link still valid to access?
I think that’s the internal Apple bug tracker and there’s no way to access it unless you are an Apple employee.