Dubious code in llvm/lib/MC/MachObjectWriter.cpp

Project Infrastructure LLVM Dev List Archives
1

In llvm/lib/MC/MachObjectWriter.cpp, there's

    assert(OS.tell() - Start == is64Bit() ?
           macho::Header64Size : macho::Header32Size);

Shouldn't that be

    assert(OS.tell() - Start == (is64Bit() ?
           macho::Header64Size : macho::Header32Size));

MSVC emits a warning, and it doesn't seem right to compare a boolean
with a difference of two integers.

Csaba

macho.diff (913 Bytes)