Enable single-line case statements in LLVM clang-format style?

[jh7370]

@kparzysz-quic

I’m late here, but I vote against allowing this. What we will end up with in some cases is a mixture of single-line and multi-line cases, depending on whether clang-format will be able to squeeze the contents into a single line. Also, the first example in this thread does not look very readable to me after being formatted:

switch (Lex.getKind()) {
default: CC = CallingConv::C; return false;
case lltok::kw_ccc: CC = CallingConv::C; break;
case lltok::kw_fastcc: CC = CallingConv::Fast; break;
case lltok::kw_coldcc: CC = CallingConv::Cold; break;
case lltok::kw_cfguard_checkcc: CC = CallingConv::CFGuard_Check; break;
}

To me this looks awful, tbh.

This example got me thinking. Could clang-format be persuaded to do the following style?

switch (Lex.getKind()) {
default:                        CC = CallingConv::C;             return false;
case lltok::kw_ccc:             CC = CallingConv::C;             break;
case lltok::kw_fastcc:          CC = CallingConv::Fast;          break;
case lltok::kw_coldcc:          CC = CallingConv::Cold;          break;
case lltok::kw_cfguard_checkcc: CC = CallingConv::CFGuard_Check; break;
}

This doesn’t look so bad, because it is much more regular. I’d also agree that if you end up with some cases that don’t fit on one line, then none of them should in the above style.