git-clang-format

Hi Daniel,

Is there any specific reason why clang/tools/clang-format/git-clang-format is a shell script with #!/usr/bin/env python as opposed to being named git-clang-format.py?

With the former, it doesn’t work on windows, whereas with the latter it does. I renamed the file to git-clang-format.py and tested it out on Windows, and it works great. So if there’s no objection I think we should rename the file.

Thoughts?

I don't have any specific problems with this plan, but one related note --
we should do something to pin it to Python 2.7 or update it to work with
Python 3.0. I've had to manually hack around this a bunch.

Ignore this message. Apparently I shouldn’t be trying to do work at 11 o’clock. :] It actually works fine without being a .py file. Python just wasn’t in my path, so it was giving me a misleading error message.

With the former, it doesn't work on windows, whereas with the latter it
does. I renamed the file to git-clang-format.py and tested it out on
Windows, and it works great. So if there's no objection I think we should
rename the file.

I vaguely object. When you run "git XYZ", git will see if there's a
binary "git-XYZ" in $PATH and use that if available. Renaming
git-clang-format makes this worse (you'd need to actually type "git
clang-format.py").

A very minor point, but then so is the Windows issue; we'd really just
be trading one platform's usability for another.

Cheers.

Tim.