GitHub monorepo and commit access

Hello,

I was wondering what was the current expected practice for committing patches to LLVM now that the Git monorepo is here.

I have commit access to SVN but when I try to land my patched through GitHub I get an error saying “Permission to llvm/llvm-project.git denied”.

Depending on the answer, the documentation might need to be slightly clarified: the getting started documents for Clang and LLVM encourage cloning from GitHub, but the Developer Policy [1] only briefly mentions SVN and the GitHub Move Proposal [2] reads “a GitHub account will be required instead of SVN username/password-hash”. In that last sentence, is the future tense still applicable?

Thanks,
Marco

[1] http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

[2] https://llvm.org/docs/Proposals/GitHubMove.html#what-this-proposal-is-not-about

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Hi Marco,

There is no commit access via the Github monorepo as things stand. SVN is still the place to commit changes to. However, for users of the monorepo, there is the ability to do “git llvm push” to push changes to the repository. See https://llvm.org/docs/GettingStarted.html#for-developers-to-commit-changes-from-git for details of hthis. I think the existing documents are still correct for now, whilst we are in the transition period. I believe the change-over to making the git monorepo the place to commit is likely to happen later this year, though others will be able to clarify this further.

James

Thanks, James, for your answer. I will give git llvm push a go.

Marco

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

I believe the change-over to making the git monorepo the place to commit is likely to happen later this year, though others will be able to clarify this further.

The fervently expressed hope, at the October 2018 Dev Meeting, was that we would "pull the trigger" during the upcoming October 2019 Dev Meeting.

I'm not aware that anyone has published any requirements/guidance regarding GitHub accounts, whether/how those should align with existing SVN accounts, etc. To date, there is no requirement to have one (which is good, because I don't). I do know that people have been experimenting with the infrastructure, hooks, tooling and so forth to make for as little disruption as we can manage, as far as developer processes go.
--paulr