Header problem on GCC 4.3

I tried to compile LLVM on Fedora 9 with GCC 4.3.
The compilation fails because UINT_MAX is not defined in file lib/Transforms/Scalar/LoopUnroll.cpp.
I included <limits.h> and everything works.

Hi,

I recently cleaned up the includes from the loop unrolling code, and this also
removed this include. It seems it's included implicitely somehow here, because
I have not problems compiling (running gcc 4.1).

However, the proper include is #include <climits>, since we're in c++, not C.

Could someone add this include to lib/Transforms/Scalar/LoopUnroll.cpp ?

Gr.

Matthijs

However, the proper include is #include <climits>, since we're in c++, not C.

Could someone add this include to lib/Transforms/Scalar/LoopUnroll.cpp ?

Done (r51145). Maybe this should go into the release too.

Ciao,

Duncan.

Hi,

> Could someone add this include to lib/Transforms/Scalar/LoopUnroll.cpp ?
Done (r51145). Maybe this should go into the release too.

I don't think the unroll changes ended up in the release, so this fix
shouldn't need to either.

Gr.

Matthijs

Could someone add this include to lib/Transforms/Scalar/LoopUnroll.cpp ?

Done (r51145). Maybe this should go into the release too.

I don't think the unroll changes ended up in the release, so this fix
shouldn't need to either.

Matthijs is right. :slight_smile:

-Tanya