How to commit patches?

Project Infrastructure LLVM Dev List Archives
#1

Hi,

I’m new to LLVM development and I can’t find enough information about how to contribute. I’ve submitted a patch on review as described in the doc:
http://llvm.org/docs/Phabricator.html

Here is the patch:
http://reviews.llvm.org/D4788

The review passed, Phabricator says that the revision is “waiting on me”. I’ve tried to run arc commit on my patch but it responds with 400 error code - Bad Request.
Possibly, I just don’t have rights for this.

What should I do next?

#2

Hi,

I'm new to LLVM development and I can't find enough information about how to
contribute. I've submitted a patch on review as described in the doc:
http://llvm.org/docs/Phabricator.html

Here is the patch:
http://reviews.llvm.org/D4788

The review passed, Phabricator says that the revision is "waiting on me". I've
tried to run arc commit on my patch but it responds with 400 error code - Bad
Request.
Possibly, I just don't have rights for this.

What should I do next?

Do you have commit access? http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

#3

Normally, you'd ask the approver to commit on the first few patches,
and after a few good ones you may request commit-after-approval access
according to the developer policy.

cheers,
--renato

#4

Thank you for clarification.

#5

Roman,

What should I do next?

Here are the complete details for getting commit access:
http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

Chad