instcombine and alias analysis (new-PM)

Project Infrastructure LLVM Dev List Archives
#1

Folks,

I have recently stumbled on the following bizarre comment in InstCombinePass::run :
// FIXME: The AliasAnalysis is not yet supported in the new pass manager
with subsequent nullptr instead of AliasAnalysis proper.

Is there any reason on why we do not pass an actual AliasAnalisys instead of that nullptr?
Here is patch that does this: ⚙ D41203 [PM][InstCombine] fixing omission of AliasAnalysis in new-pass-manager's version of InstCombine

regards,
Fedor.

#2

Closing the loop (Already replied to patch) I think this is just an oversight since the AA support landed. Thanks for fixing!