Interpreter improvement

Hi,
I going through the Interpreter class source code and I think making almost all the visit methods (maybe not visitInstruction yet) would really help anybody that wants to create any sort of tracer or similar. Would be a patch in this case worthy?

Thanks

I dont quite understand the meaning of making almost all the visit methods, care to explain?

On a side note, last time I checked that part I think it probably needs a full rewrite from ground up IMHO

Zhang

Hi,
I my case I needed to trace the execution of a specific .ll file. I wanted to know when a store and load instruction were executed. Maybe extending the Interpreter class was not the best option so I’m happy to hear suggestions.

As a curiosity, why do you think that class should be rewritten?

Thanks

Well for my designed use case I plan to use it to interpret IR in production environment. As such I remember there were quite some issues with it, on top of my head is support for var_arg native function calling

Zhang

Ok there might other I don’t know as well…

But apart from that, how would you using that class without overriding the visit methods?