Is RequestReturnValue still relevant

In ThreadPlanCallFunction.h I saw

67 // To get the return value from a function call you must create a
68 // lldb::ValueSP that contains a valid clang type in its context and call
69: // RequestReturnValue. The ValueSP will be stored and when the function is
70 // done executing, the object will check if there is a requested return
71 // value. If there is, the return value will be retrieved using the

I suspect this comment is just outdated, but is there anything special that needs to be done in order to be able to get the return value?

Keno

That comment is outdated. I don't remember what it was there for originally, svn says it is Greg's. Maybe he remembers.

Anyway, you shouldn't need to do anything special to get the return value object out of a ThreadPlanCallFunction, just set up the arguments, run the plan (with RunThreadPlan) and then call GetReturnValueObject on the thread plan (provided it succeeds of course...)

ThreadPlanCallUserExpression is more complex, but that's really only used with ClangUserExpression at present, if you are trying to get something in the target process using a function call on the lldb_private side of things you should use ClangFunctions, or use ThreadPlanCallFunction & RunThreadPlan.

What are you trying to do?

Jim

That comment is outdated. I don't remember what it was there for
originally, svn says it is Greg's. Maybe he remembers.

Ok, great thanks. I think that comment can be deleted then, so I'll go
ahead and do that.

What are you trying to do?

I'm building a different front end on top of LLDB and that comment
confused me because it seemed to work fine without, but I wanted to make
sure I wasn't missing something that would come back to bite me. At the
current step, my goal is to
run some locally generated IR in the remote process, which I think I now
managed to do.