KMP_IOMP_NAME

Jonathan,
      What is the definition of...

#define KMP_IOMP_NAME "Intel(R) OMP"

in runtime/src/kmp.h used for? I don't see any usages within the
current openmp and cfe sources. If it needs to be retained, should't
it be transformed into...

#define KMP_OMP_NAME "LLVM* OMP"

       Jack

I think it is better to remove unused things rather than rename.

- Andrey

Andrey,
     I've been wondering how much dead-code got dragged in with the
bulk merge of the openmp tree (since there really wasn't the normal
code-review during that process). Perhaps just as important as adding
more OpenMP 4.x support would be going through the openmp codebase and
making sure dead legacy code from earlier versions of iomp has been
purged out.
          Jack

Jonathan,
      It appears that...

GetNewerIOMPLibrary "You may want to use an %1$s library that
supports %2$s interface with version %3$s."

and

GetNewerIRMLLibrary "You may want to use an %1$s library with
version %2$s."

are dead code in runtime/src/i18n/en_US.txt and can be removed as well.
         Jack

I've been burned on this before. When editing the en_US.txt message catalog file, you can't delete lines because of the way some data structures and enum's are generated (see the generated files kmp_i18n_default.inc and kmp_i18n_id.inc after you build). You have to put OBSOLETE in place of the name. So I could do:

OBSOLETE "You may want to use an %1$s library that supports %2$s interface with version %3$s."
and
OBSOLETE "You may want to use an %1$s library with version %2$s."

-- Johnny

I've been burned on this before. When editing the en_US.txt message catalog file, you can't delete lines because of the way some data structures and enum's are generated (see the generated files kmp_i18n_default.inc and kmp_i18n_id.inc after you build). You have to put OBSOLETE in place of the name. So I could do:

OBSOLETE "You may want to use an %1$s library that supports %2$s interface with version %3$s."
and
OBSOLETE "You may want to use an %1$s library with version %2$s."

Jonathan,
      Might as well mark them as OBSOLETE so that they will get purged
on the next library version change.
                  Jack

Jack,

Sorry for late response.
I couldn't agree with you more, our library is not perfect here, it needs a lot of clean up.

And thank you for pointing to the issues.

- Andrey