Landing my new development on the trunk ...

I am currently writing a new optimization pass for LLVM, based on the paper Operator Strength Reduction (Taylor Simpson et al, 2001). I noticed from the Developer Policy page that my code will need to be reviewed before it is committed to the trunk.

The Policy page also indicated that all "major" changes should to be announced before coding and should be done as a series of incremental changes. I am not sure a new stand alone optimization pass counts as a major change or not.

I have run my pass against the test suite (as described here: "How to test my pass" http://comments.gmane.org/gmane.comp.compilers.llvm.devel/32875). I have fixed all of the compilation errors and all but one of the execution errors.

I have made a pass over my code to conform to the LLVM coding standards.

I have not written the regressions tests yet.

I also still need to work on the performance, but as is it is faster than the existing -loop-reduce pass.

My question is how to proceed. What steps do I need to take to get my code reviewed and committed to the trunk?

thanks,
Brian West

Hi Brian,

My question is how to proceed. What steps do I need to take to get my
code reviewed and committed to the trunk?

the first step is to send a patch adding your pass (and hopefully the
associated documentation!) to LLVM to the mailing list, so that others
can test and study your code.

Ciao,

Duncan.