[libcxx] Problem with quick_exit test

Clang Frontend
1

Hi,

test/language.support/support.start.term/quick_exit.pass.cpp uses std::at_quick_exit() to test quick exit functionality. But looking at include/cstdlib header inside libcxx at_quick_exit function is not defined in the std namespace.

Changing the test to use at_quick_exit(f) without the namespace fixes the build for me.

Is this an oversight or am I missing something?

Thanks,
ismail

2

It sounds like <__config> needs to turn on _LIBCPP_HAS_QUICK_EXIT for your platform. Currently <__config> says:

#if defined(__FreeBSD__) && (__ISO_C_VISIBLE >= 2011 || __cplusplus >= 201103L)
#define _LIBCPP_HAS_QUICK_EXIT

Perhaps you could test & submit a patch to fix this?

Howard

3

Fencepost comment - Instead of a platform #if - could this be turned into a feature check? (I'm just curious if _LIBCPP_HAS_QUICK_EXIT is really limited to FreeBSD only..

4

I've implemented auto-detection of the existence of namespace scope functions before, but it was a long time ago, and was pretty messy. I'm open to suggestions on how to do the feature check.

Howard

5

Hi,

quick_exit_linux.patch (493 Bytes)

6

Thanks, Committed revision 181612.

Howard