[libcxx] test/lit.cfg patch

Clang Frontend
#1

Hi,
   I discovered that when testing libc++ with cmake/lit (make check-libcxx), it was choosing an installed clang++ from my $PATH over the value passed in ${builddir}/test/lit.site.cfg (which is an uninstalled clang++). The attached patch fixes this, and seems to match the comment in context. Ok to commit?

David

cxx_under_test.patch (546 Bytes)

#2

Hi,

Here's another revision of the patch that doesn't call lit.util.which when cxx_under_test is already !None. In either case, lit_config.note() still reports the value of cxx_under_test, makes sure user is running the intended clang++ binary.

LGTY?

David

cxx_under_test.patch (944 Bytes)

#3

Hi,

Here's another revision of the patch that doesn't call lit.util.which when cxx_under_test is already !None. In either case, lit_config.note() still reports the value of cxx_under_test, makes sure user is running the intended clang++ binary.

LGTY?

LGTM.

— Marshall