Hi Joerg,
Is this to libc++abi in the libc++ repo, or is it already in the
compiler-rt repo?
Would be good to get all those implementations upstream as we move.
What's holding you from merging?
cheers,
--renato
Is this to libc++abi in the libc++ repo, or is it already in the
compiler-rt repo?
It's derived from the libunwind in libc++abi.
Would be good to get all those implementations upstream as we move.
What's holding you from merging?
Time...
Joerg
excellent.
questions:
1) will this work allow c++ exceptions to work correctly on ppc-elf programs utilizing clang and libc++?
2) I assume it wouldn’t be hard to port it to linux?
The undwinder still seems to be in the libc++abi repo, in spite of the broad consensus that it should be in compiler-rt and the fact that we've subsequently had people look in compiler-rt, find no unwinder, and say on the mailing list 'since LLVM doesn't have a generic unwinder...'.
What are we waiting for to move it? Sign-off from Apple that it won't break their build? People with outstanding changes to commit them?
David
David - maybe just move it if nobody objects by next Monday. I think the biggest thing would be ensure you don't break any buildbots in the process.
Is it currently built by any of the buildbots? I don't see any build infrastructure for it at all.
David
My guess is probably not, but it was just the 1st thing which came to mind. This is clearly overdue and probably just nobody else has the time to do it. Give people some time to object and if nobody does - move it
As always -- if someone would be kind enough to prepare a zorg script,
I would be happy to host a builder.
Dmitri
Hi Dmitri,
Shouldn't be too hard. I've linked --rtlib on Linux in Clang, and it
should just work (if not, should be easy to fix), so it should be just
a matter of using LNTBuilder + "--rtlib=compiler-rt". However, because
of the lack of libunwind, it's still using libgcc_s and libgcc_eh,
which I haven't linked yet because the location wasn't defined.
I just finished working on the RT side (test-suite passes green on
ARM), so I'll look into libunwind in the near future. But, if someone
moves it to RT first, I'll gladly test and link it up in case all
works on at least x86_64 and ARM.
cheers,
--renato