[lld] ELF/AArch64 support in lld

I’ve been implementing ELF/AArch64 support for lld. I can now successfully link and run a simple “Hello World” app for both dynamic and static linking. I’d like to upstream this implementation, but wanted to get feedback on how people might like to see it. Would people rather see the whole thing in one shot, each file individually or somehow break it down even farther? The implementation obviously requires all the files due to their interplay, so I’m not sure how only some files could be committed without the others.

I don’t yet have tests for everything; is it possible to upstream now or wait until I have a complete test suite in place as well?

Trying to get feedback now to make the process as smooth as possible.

Thanks,

Daniel

Cool! Starting the review process with just one patch is fine by me.
Can you please post it to Phabricator?

http://reviews.llvm.org/

Thanks,
Greg

Yes, please! Copy me to the reviews, too.

--renato

Daniel,
I suggest uploading your complete patch to Phabricator (see:
http://reviews.llvm.org/).

Chad

Hi Daniel,

We would need a testcase before you commit the change to the repository.

This is to make sure future patches dont break functionality already addressed.

Shankar Easwaran

Shankar,

I’ll try to add test cases before it gets committed. But I’ll start the process to get it up on Phabricator to at least allow people to give feedback. Since I fully believe there will be comments I have to address anyway, I’ll be able to add test cases at the same time.

Daniel

Shankar,

I’ll try to add test cases before it gets committed. But I’ll start the process to get it up on Phabricator to at least allow people to give feedback. Since I fully believe there will be comments I have to address anyway, I’ll be able to add test cases at the same time.

Daniel