[Lldb-commits] [lldb] r226234 - Add Socket::Get[Remote/Local]IpAddress and unit tests

Subprojects LLDB
#1

Vince Harron schreef op 1/16/2015 om 1:47 AM:

Author: vharron
Date: Thu Jan 15 18:47:08 2015
New Revision: 226234

URL: http://llvm.org/viewvc/llvm-project?rev=226234&view=rev
Log:
Add Socket::Get[Remote/Local]IpAddress and unit tests

Differential Revision: http://reviews.llvm.org/D6917

Added:
     lldb/trunk/gtest/unittest/Host/
     lldb/trunk/gtest/unittest/Host/Makefile
     lldb/trunk/gtest/unittest/Host/SocketAddressTest.cpp
     lldb/trunk/gtest/unittest/Host/SocketTest.cpp
     lldb/trunk/gtest/unittest/Host/SocketTestMock.cpp
Modified:
     lldb/trunk/gtest/gtest.xcodeproj/project.pbxproj
     lldb/trunk/include/lldb/Host/Socket.h
     lldb/trunk/include/lldb/Host/SocketAddress.h
     lldb/trunk/source/Host/common/Socket.cpp
     lldb/trunk/source/Host/common/SocketAddress.cpp
     lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp

Looks like the open { after the case in:
lldb/trunk/source/Host/common/SocketAddress.cpp line 42 is not properly closed.

#2

Will fix ASAP

#3

I did my best. I’m still unable to get Windows building.

http://reviews.llvm.org/rL226301

#4

I will sync to ToT and fix up remaining windows issues.

#5

Looks ok to me, I’m not getting any errors.