[LLParser] Remove deplibs related defines and functions

Project Infrastructure LLVM Dev List Archives
1

Hi folks!

I plan to remove some outdated defines and functions related to deplibs in LLParser/LLLexer as the comment suggested they should be removed in 4.0 (e.g, see: https://github.com/llvm/llvm-project/blob/57ea5d4f48754b9b3470fceb197a56ed938ddc02/llvm/lib/AsmParser/LLParser.cpp#L465).

The purposed change will delete several functions and you can take a look at https://reviews.llvm.org/D102763. The removal itself is pretty trivial, but as Saleem suggested in the review, it may have potential impact to any down-stream projects. So I am posting this here to make sure we have a good understanding on the impact before the actual removal.

Thanks!

Best,
Xuanda Yang

2

Seems ok to me, if it causes a problem for anyone the fix in the .ll file will be trivial.

-Chris

3

I tried this cleanup in 2020, but a point was raised that this can be
used to read old bitcode files. See ⚙ D73422 [IR] Delete MODULE_CODE_DEPLIB

4

I tried this cleanup in 2020, but a point was raised that this can be
used to read old bitcode files. See ⚙ D73422 [IR] Delete MODULE_CODE_DEPLIB

D73422 removed both textual IR parsing and bitcode reading. Textual IR
never really had any backward-compatibility guarantees. The new patch
removes only textual IR parsing, it does not remove bitcode reading; it
should be fine to do this.
--paulr

5

Right

-Chris

6

Thanks for the input! Especially thanks for bringing up the last attempt to remove these functionalities so we can figure out it’s safer to do so with the textual IR. Let’s wait til Jun 2nd, if no other objections are purposed I will continue with the revision.

Xuanda

Chris Lattner <clattner@nondot.org> 于2021年5月28日周五 上午12:20写道：