LLVM 19.1.0-rc2 tagged

[hansw2000]

@tstellar

The Windows builds I uploaded were built using this workflow. The workflow uses the release CMake cache file and the stage2-package build target.

Besides not being an installer, the other difference compared to the build_llvm_release.bat script is that PGO is not enabled for the builds (I am working on this and hope to have it done soon).

I don’t think we can run the build_llvm_release.bat script on the free runners due to the job timeouts, so I think we have 3 options:

1. Have @hansw2000 upload Windows builds as normal.
2. Pay for a more powerful runner from GitHub and run build_llvm_release.bat (we have some budget for this already).
3. Modify the current workflow to build an installer and enable PGO (this is the long-term plan, but probably won’t be ready in time for 19.1.0-final).

With LLVM 19-final drawing closer, we need to resolve this. I have already received one email asking why the installer isn’t on the release page, and I expect there will be many more once we actually release.

My read of [RFC] Improve binary security is that we landed in

@tobiashieta

If we can’t have CI built windows binaries ready for LLVM 19 we will allow Hans to continue to build these and upload them. With the understanding that we should replace these as well.

So it sounds like we’re doing 1) except the Windows binaries are currently not appearing on the release page. Should I just upload them there directly?

Long term, I think it would be fantastic if these could be built automatically, but it seems like we’re not there yet.