[llvm-commits] patch to enable response file support in ParseCommandLineOptions

Thanks Chris for the comment.

Since there is no objection, I attached a new patch which enables response file support and removes the argument for controlling/disabling response file support. The patch also contains a simple test. I did regression check and there are no regressions.

  • llvmdev

Sam

ResponseFile.patch (4.49 KB)

Can we call this a "parameters file"? I find "response file" to be non-obvious.

Response file is the conventional name for files serving this purpose. A google search shows the usage of "response file" is not rare. Also it has been used in the LLVM documentation:

http://llvm.org/docs/CommandLine.html#response-files

Sam

This is also a common term on Windows, where response files are the usual hack around their design deficiencies that limit command line length.

Alex

Looks good to me,

-Chris