llvm-diff

I was wondering about IR comparison and I saw llvm-diff tool, why is
it not installed by default when I make install?

Probably because I missed some vital way of plugging into the build system.

Note that llvm-diff is meant solely as a tool for debugging IR; pretty much all
details of the output, from formatting to actual information, is subject to change.

John.

John McCall <rjmccall@apple.com> writes:

I was wondering about IR comparison and I saw llvm-diff tool, why is
it not installed by default when I make install?

Probably because I missed some vital way of plugging into the build system.

List it on tools/Makefile and tools/CMakeLists.txt along the other tool
directory names.

[snip]

Hi John,

This is fine, I'll not use it on any production system nor rely on its
output for anything, it's also mainly for IR debugging.

I noticed you have virtual functions but non-virtual destructor on
Oracle and Consumer. It might not matter much at this stage, as
they're not extended, but it's good to fix it. :wink:

Note that llvm-diff is meant solely as a tool for debugging IR; pretty much all
details of the output, from formatting to actual information, is subject to change.

This is fine, I'll not use it on any production system nor rely on its
output for anything, it's also mainly for IR debugging.

Well, I hope it's useful; feel free to contribute changes.

I noticed you have virtual functions but non-virtual destructor on
Oracle and Consumer. It might not matter much at this stage, as
they're not extended, but it's good to fix it. :wink:

I'll "fix" it on the day it seems like a good idea to layer a API on top
of DifferenceEngine that takes ownership of an Oracle of unknown
type. I'm not sure why that would ever happen. :slight_smile:

John.

I was going to do that myself when I found yours. :wink:

Will send patches if I need any extra...