llvm-mc-assemble-fuzzer broken

Project Infrastructure LLVM Dev List Archives
#1

While playing with sanitizer in a downstream project, I found out this.

/Users/davide/work/llvm-monorepo/llvm-project-20170507/llvm/tools/llvm-mc-assemble-fuzzer/llvm-mc-assemble-fuzzer.cpp:207:32:
error: reference to type 'std::unique_ptr<MCCodeEmitter>' could not
bind to an
lvalue of type 'llvm::MCCodeEmitter *'
        UseDwarfDirectory, IP, CE, MAB, ShowInst));
                               ^~
/Users/davide/work/llvm-monorepo/llvm-project-20170507/llvm/include/llvm/Support/TargetRegistry.h:514:66:
note: passing argument to parameter 'CE' here
                                std::unique_ptr<MCCodeEmitter> &&CE,
                                                                 ^
/Users/davide/work/llvm-monorepo/llvm-project-20170507/llvm/tools/llvm-mc-assemble-fuzzer/llvm-mc-assemble-fuzzer.cpp:232:55:
error: too many arguments to function call, expected 3, have 4
                                                      MCOptions);
                                                      ^~~~~~~~~
/Users/davide/work/llvm-monorepo/llvm-project-20170507/llvm/include/llvm/Support/TargetRegistry.h:401:3:
note: 'createMCAsmBackend' declared here
  MCAsmBackend *createMCAsmBackend(const MCSubtargetInfo &STI,
  ^
2 errors generated.

Apparently, this has been broken for several months. I think I can fix
this particular instance, but I was wondering whether anybody cares
about this tool?

#2

It worked in August.
Last time I’ve asked (again, in August) someone did seem to care,
but it is inevitable it would bitrot if it’s not built in any of the bots.

George

#3

Thank you.
I went ahead with a speculative fix in r331568.
I'm not familiar _at all_ with the tool, so, although the fix was
straightforward, another pair of eyes from somebody familiar with the
tool would be appreciated.

#4

rL331568 looks good to me.

Thank you.
I went ahead with a speculative fix in r331568.
I’m not familiar at all with the tool, so, although the fix was
straightforward, another pair of eyes from somebody familiar with the
tool would be appreciated.

It worked in August.
Last time I’ve asked (again, in August) someone did seem to care,
but it is inevitable it would bitrot if it’s not built in any of the bots.

That was me. I still have a task on my todo list to set up a bot for this but it keeps being pushed back by other priorities.